Re: Need some feedback

PS: Cleaned up the code a bit and added transparency to the logo :slight_smile:

At the risk of offending you again :wink: it all looks pretty cool. Here’s some (possibly) useful suggestions, feel free to ignore:

  • You call view.stopView() but you never call view.startView().

  • The DisplayOptions dialog is sweet, but you might find it easier later pulling it out into a seperate class.

  • This one is a matter of taste I guess. The keyboard stuff is great but again it might be nicer in a seperate class. I think this only matters if you’re going to use this framework for more than demos.

  • If you want to do listeners embedded into the main class you could use inner classes and extend the Adapter classes (e.g. MouseAdapter). This stops you having to have a bunch of empty methods defined. It also stops the public external interface of your frame having the event methods exposed.

  • I’m not sure how many key codes are defined, it might be more than 255. Can check or use KeyEvent.KEY_LAST to find out.

But as I said, in general, looks cool. I especially like the Powered By bit in the select screen mode. Is it going to change depending on whether you’re using Java3D / Jogl / Xith ?

But arn’t you jumping the gun a bit? We’ve got to vote on that logo yet :slight_smile:

Kev

Great feedback Kev: like I said before I’m over what happened few months ago.
As a matter of fact, if it wasn’t for the little heated debate that we had, I would still be using C naming convention which I absolutely loath nowadays ;D.
I like most of what you said so far and I’ll be implementing it whenever I get free time.
To answer your question on why I call stopView() and yet ignore calling startView():
Since my run() method is still running, you can see that view.renderOnce() is called over and over again, therefore resuming the display :P.
startView() will call an unnecessary loop that ain’t synchronized with my main class.
Oh and I kinda adore that logo that Im using :stuck_out_tongue:

Here is my minor [minor!] points:

  • 1600 x 1200. I run this resolution almost on all of my computers…

  • Window close should work on both dialog and rendering window. Now, after closing the Xith3D rendering window, the app does not exit.

  • Would like to define default resolution somewhere (say, in system properties using -D to save some clicks when debugging (i.e. when sys props set, then no need in screen mode chooser).

The rest is cool.

Yuri

Yep, I got that. Just if you don’t call startView() you don’t need to call stopView(), at least I don’t think so. Incidently, the sorta immediate mode rendering (calling renderOnce() over and over) is exactly what I do :slight_smile:

Kev

http://www.realityflux.com/abba/displaySettings.jpg

The display manager now comes in a separate class
get it here

Here’s a quick tutorial on how to use it.
Don’t forget to put the jar file in your class path.
The source is provided as well in case you wanna play around a bit with it, enjoy :stuck_out_tongue:

Testing Java Web Start on my new web space.
Thank you William :slight_smile:

java.lang.NoClassDefFoundError: javax/vecmath/Tuple3f

[quote]java.lang.NoClassDefFoundError: javax/vecmath/Tuple3f
[/quote]
Looks like only the xith3d and JOGL libraries are included in the JWS (if you have vecmath.jar in your classpath then it should work…)

Will.

Got some layout issues on OS X 10.3.1

http://www3.sympatico.ca/scott.palmer/xith_display.png

followed by:
Error: empty view at “src/native/jogl/MacOSXWindowSystemInterface.m:createContext:24”

Lemmie fix the layout.
I dunno about the error though :’(