Problem building mipmaps on OSX

abegel · April 26, 2005, 4:46am

I’m having a problem building a 2D mipmap on JOGL 1.1b10 on OSX 10.3.9 (Powerbook G4 ATI Radeon 9700 card). No matter what image I send to the function, it keeps giving me a GL_INVALID_VALUE exception inside of an internal call to glTexImage2D. Here’s the code:

        glu.gluBuild2DMipmaps( texture.target, 
                                   texture.dstPixelFormat, 
                                   texture.width, 
                                   texture.height,
                                   texture.srcPixelFormat, 
                                   GL.GL_UNSIGNED_BYTE, 
                                   texture.byteBuffer );

where, texture.target is GL_TEXTURE_2D, dstPixelFormat is GL_RGBA, srcPixelFormat is GL_RGBA, width and height are 256 and byteBuffer points to image data loaded from a PNG file (which looks ok with Preview).

The error I get is this:

Initializing new texture 22 - /Users/abegel/Developer/eandl/starlogo-tng/build/models/hulk/blue.png
building mipmap for image width: 256 height: 256
net.java.games.jogl.GLException: glGetError() returned the following error codes after a call to glTexImage2D(): GL_INVALID_VALUE
at net.java.games.jogl.DebugGL.checkGLGetError(DebugGL.java:13901)
at net.java.games.jogl.DebugGL.glTexImage2D(DebugGL.java:10554)
at net.java.games.jogl.impl.mipmap.Mipmap.closestFit(Mipmap.java:259)
at net.java.games.jogl.impl.mipmap.Mipmap.gluBuild2DMipmaps(Mipmap.java:676)
at net.java.games.jogl.impl.GLUImpl.gluBuild2DMipmapsJava(GLUImpl.java:587)
at net.java.games.jogl.impl.GLUImpl.gluBuild2DMipmaps(GLUImpl.java:823)
at torusworld.TextureManager.initTexture(TextureManager.java:186)
at torusworld.TextureManager.initNewTextures(TextureManager.java:137)
at torusworld.TorusWorld.drawTurtle(TorusWorld.java:2076)
at torusworld.TorusWorld.renderMobileObject(TorusWorld.java:2024)
at torusworld.TorusWorld.renderMobileObjects(TorusWorld.java:1957)
at torusworld.TorusWorld.drawIt(TorusWorld.java:1874)
at torusworld.TorusWorld.display(TorusWorld.java:1249)
at net.java.games.jogl.impl.GLDrawableHelper.display(GLDrawableHelper.java:74)
at net.java.games.jogl.GLCanvas$DisplayAction.run(GLCanvas.java:241)
at net.java.games.jogl.impl.GLContext.invokeGL(GLContext.java:292)
at net.java.games.jogl.impl.macosx.MacOSXOnscreenGLContext.invokeGL(MacOSXOnscreenGLContext.java:84)

Using Apple’s OpenGL Profiler, I found the arguments for the offending glTexImage2D() call at the end of this sequence (the calls above it are definitely my own that happen before the gluBuild2DMipmap code):

/* context 0x023a9800 / glGenTextures(14, 0x49ff88ec);
/ context 0x023a9800 / glGetError(); / returns: GL_ZERO /
/ context 0x023a9800 / glBindTexture(GL_TEXTURE_2D, 18);
/ context 0x023a9800 / glGetError(); / returns: GL_ZERO /
/ context 0x023a9800 / glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_WRAP_S, GL_CLAMP);
/ context 0x023a9800 / glGetError(); / returns: GL_ZERO /
/ context 0x023a9800 / glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_WRAP_T, GL_CLAMP);
/ context 0x023a9800 / glGetError(); / returns: GL_ZERO /
/ context 0x023a9800 / glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MIN_FILTER, GL_LINEAR);
/ context 0x023a9800 / glGetError(); / returns: GL_ZERO /
/ context 0x023a9800 / glTexParameteri(GL_TEXTURE_2D, GL_TEXTURE_MAG_FILTER, GL_LINEAR);
/ context 0x023a9800 / glGetError(); / returns: GL_ZERO /
/ context 0x023a9800 / glGetString(GL_VERSION);
/ context 0x023a9800 / glGetError(); / returns: GL_ZERO /
/ context 0x023a9800 / glTexImage2D(GL_PROXY_TEXTURE_2D, 1, GL_RGBA, 64, 64, 0, GL_RGBA, GL_UNSIGNED_BYTE, 0x00000000);
/ context 0x023a9800 / glGetError(); / returns: GL_INVALID_VALUE */

Any idea what I can do to debug this further? This works perfectly with the same JOGL on a PC running WinXP with an NVidia card.

Thanks,

Andrew

ozak · April 26, 2005, 9:19am

I got the same error. It appears your textures should be power of 2 in size. Then it works for me on ATI cards.

kbr · April 26, 2005, 1:03pm

Does it work if you specify the system property -Djogl.glu.nojava on the command line? That would indicate a bug in the Java port of the mipmap routines and in that case I’d appreciate it if you could file a bug with the Issue Tracker on the JOGL home page and attach your example texture and a small test program.

Does the behavior change if you run with -Xint?

Is that output from exactly the source image you’re specifying? It looks like it’s at level 1 but the image size is 64x64; if you have a 256x256 base image then mipmap level 1 should be 128x128. Maybe that’s the problem. The log and image size computation routines are really simple, so it’s surprising if they’re producing incorrect results.

I noticed the Apple OpenGL profiler seems to be reporting strange arguments like GL_PROXY_TEXTURE_2D instead of GL_TEXTURE_2D; I assume this is due to how the profiler works. Does JOGL’s TraceGL report similar arguments?

ozak · April 26, 2005, 3:37pm

It is a problem with the texture size not being a power of two.
I just thought that the glu mipmap thingie took care of that. Guess not

kbr · April 26, 2005, 4:13pm

Why do you think it is a problem with the texture size not being a power of two? His input image is 256x256.

abegel · April 26, 2005, 5:34pm

Added -Djogl.glu.nojava makes my program succeed. And I miswrote earlier. The original texture is 128x128, not 256x256.

According to the Java code in mipmap.Mipmap.closestFit() in Mipmap.java:259, the GL_PROXY_TEXTURE_2D argument to glTexImage2D() is passed explicitly and on purpose.

I haven’t used JOGL’s TraceGL before. I’ll read up on it and figure out how to use it.

I’ll also report this as a bug on the Issue tracker.

kbr · April 26, 2005, 7:19pm

Please do file the bug. However it looks like this is the intended behavior of the GLU code, both the original C and the Java port. If proxy textures aren’t supported by the hardware (and it looks like they aren’t on ATI cards) then the code is supposed to go to a fallback path which doesn’t attempt to figure out whether the subsampled texture will fit in texture memory. If you take out the DebugGL does your program work with the Java port of the GLU routines? We might need to add an API to disable the DebugGL’s error checking around calls like this, or try to rewrite this part of the GLU routines to not generate GL errors.

kbr · April 26, 2005, 7:31pm

Actually on further examination it looks like it is probably a driver bug that ATI hardware raises an error upon receiving a target of GL_PROXY_TEXTURE_2D.

abegel · June 4, 2005, 6:00am

I just tried my code with JOGL 1.1b12 and there’s been progress! With the java version of the glu library, some of my mipmaps are built correctly!

The ones that fail are mipmaps made from 1x1 textures. There’s a bug in the algorithm in BuildMipmap.java:gluBuild2DMipmapLevelsCore() when width, height, widthPowerOf2 and heightPowerOf2 are equal to 1. We enter the if statement (if (width == newwidth && height == newheight)) and get down to the switch(type) statement where I’m passing in GL.GL_UNSIGNED_BYTE, so we call HalveImage.halveImage_ubyte() with width and height = 1. But halveImage_ubyte() has an assertion that width and height can’t both be 1 so we fail.

There’s obviously a bug in the control flow here. Here’s a stack trace of the error:

Caused by: java.lang.AssertionError
at net.java.games.jogl.impl.mipmap.HalveImage.halveImage_ubyte(HalveImage.java:95)
at net.java.games.jogl.impl.mipmap.BuildMipmap.gluBuild2DMipmapLevelsCore(BuildMipmap.java:365)
at net.java.games.jogl.impl.mipmap.Mipmap.gluBuild2DMipmaps(Mipmap.java:719)
at net.java.games.jogl.impl.GLUImpl.gluBuild2DMipmapsJava(GLUImpl.java:587)
at net.java.games.jogl.impl.GLUImpl.gluBuild2DMipmaps(GLUImpl.java:823)
at torusworld.TextureManager.initTexture(TextureManager.java:196)
at torusworld.TextureManager.initNewTextures(TextureManager.java:146)
at torusworld.TorusWorld.drawTurtle(TorusWorld.java:2111)
at torusworld.TorusWorld.renderMobileObject(TorusWorld.java:2059)
at torusworld.TorusWorld.renderMobileObjects(TorusWorld.java:1990)
at torusworld.TorusWorld.drawIt(TorusWorld.java:1907)
at torusworld.TorusWorld.display(TorusWorld.java:1275)
at net.java.games.jogl.impl.GLDrawableHelper.display(GLDrawableHelper.java:74)
at net.java.games.jogl.GLCanvas$DisplayAction.run(GLCanvas.java:249)
at net.java.games.jogl.impl.GLContext.invokeGL(GLContext.java:292)
at net.java.games.jogl.GLCanvas$DisplayOnEventDispatchThreadAction.run(GLCanvas.java:266)

kbr · June 4, 2005, 7:08pm

Could you file a bug with the JOGL Issue Tracker and attach the texture and code snippet you’re calling gluBuild2DMipmaps with?

kbr · June 5, 2005, 5:49am

I’m pretty sure I found the bug (a missing return statement in BuildMipmap.gluBuild2DMipmapLevelsCore() and just checked in a fix - untested, however. If you have the time to write up a small test case that would be helpful. Regardless, the fix will be in the next JOGL release.

abegel · June 6, 2005, 1:23am

Yep, Ken, that change to BuildMipmap.java fixed it. Thanks!

BTW, I really want to submit a test case, but can’t easily build one out of my code (it’s way too big and involves C and Java in addition to the jogl stuff). Sorry about that.

Andy