PickingLibrary and setPickable

hi

Since picking using the PickingLibrary just ignores the getPickable() method, there’s a problem using e.g. transparent geometries which should be ignored by any picking routine.

How about inplementing two new methods in the Node class named

setPickingIgnored(boolean) or setIgnoredByPicking(boolean)
and
boolean getPickingIgnored() or boolean getIgnoredByPicking()

which are respected by PickingLibrary?

Of course this wouln’t increase performance like setPickable/getPickable did for the old picking system, but O(log n) is not beatable and enough. And I just need such a flag.

What do you say?

Qudus

It’s really easy to implement but Arne and I didn’t made it cause we didn’t needed it ! If you find it useful, please do !
(I have a separate pickable() branchGroup which contains all the pickable geometries… But maybe a pickable flag would help)

[quote="<MagicSpark.org [ BlueSky ]>,post:2,topic:27608"]
It’s really easy to implement but Arne and I didn’t made it cause we didn’t needed it ! If you find it useful, please do !
(I have a separate pickable() branchGroup which contains all the pickable geometries… But maybe a pickable flag would help)
[/quote]
I know it’s easy and I would like to implement it, but Will didn’t show any lifesigns so far for my request of CVS access. Neither on PM nor by email.

I know it’s easy and I would like to implement it, but Will didn’t show any lifesigns so far for my request of CVS access. Neither on PM nor by email.
[/quote]
Hmm… too bad… I wish I had permissions to grant you Dev access but unfortunately I don’t.
Did I mentioned you need to :

  • register on dev.java.net
  • request the “Developer” role in the xith-tk
    ?

[quote="<MagicSpark.org [ BlueSky ]>,post:4,topic:27608"]
Hmm… too bad… I wish I had permissions to grant you Dev access but unfortunately I don’t.
Did I mentioned you need to :

  • register on dev.java.net
  • request the “Developer” role in the xith-tk
    ?
    [/quote]
    No, you didn’t. I just asked Will by PM and mail. I will register in a few minutes.

Just a remark on adding some kind of ignorePicking flag to the com.xith3d.Node class. It lays in the core lib. So I cannot add such a flag to it. So what did you mean by “If you find it useful, please do !”?

Ah sorry I didn’t read your whole first message… I thought you just wanted to make Arne’s picking code pickable-flag-aware. Hmm… this is not necessary to add the flag you suggest to Node ! Just modify the picking routine to make it :

  • get the appearance (test if it’s not null)
  • get the transparency (test if it’s not null)
  • if transparency.alpha = 0f (or 1f I can’t remember), then ignore it

[quote="<MagicSpark.org [ BlueSky ]>,post:7,topic:27608"]
Ah sorry I didn’t read your whole first message… I thought you just wanted to make Arne’s picking code pickable-flag-aware. Hmm… this is not necessary to add the flag you suggest to Node ! Just modify the picking routine to make it :

  • get the appearance (test if it’s not null)
  • get the transparency (test if it’s not null)
  • if transparency.alpha = 0f (or 1f I can’t remember), then ignore it
    [/quote]
    I don’t think this’d be universal. Maybe someone actually wants to pick a (semi) transparent geometry. And a flag would grant a much higher performance.

I just checked out the xith-tk cvs source and added my classes and changes. But I cannot do a CVS-add. How long does it take until my access get (totally) enabled? Or do I have to do something on my own to remove that “(Pending)” on my cvs developer role?

[quote]I just checked out the xith-tk cvs source and added my classes and changes. But I cannot do a CVS-add. How long does it take until my access get (totally) enabled? Or do I have to do something on my own to remove that “(Pending)” on my cvs developer role?
[/quote]
you’ll have to wait until Will (or another Project Owner) approves your role

you’ll have to wait until Will (or another Project Owner) approves your role
[/quote]
I requested Projet Owner role on xith-tk so when I am I can further grant Dev access to serious Devs. (I have more free time than Will).