What do you all think about making fields public that have simple setters/getters? Part of my problem is that since I started using State classes, they have to access the basic Mob fields (x, y, xa, ya, etc) through setters and getters since they are not the same class and don’t reside in the same package. When field access is heavy, the setters/getters (setters more than getters, really) make the code hard to read.
So is there really any harm in making Mob fields public, since setters/getters make them essentially public in practice anyways?
Here is an example:
Player extends Mob
PlayerNormalState extends State
Player contains a State field, which currently points to an instance of PlayerNormalState
PlayerNormalState::update() updates the fields x, xa, etc. that are defined in Mob, but needs to use setters/getters since those fields are protected, making the code much harder to read and write.
Should I just make those fields public?
Keep in mind, I’m talking about setters & getters that simply assign and return values; not specialized ones that do extra computations like range checking and such.