Integer is not getting repaint?!

Newbie & Debugging Questions
#1

Hi!
My Items are drawn in the Item Menu. Like:
Potion x5 Antidote x2

I draw the Item with this:


for( x=0;x<ItemList.size();x++)
             {
                 //This is only for the coordinates
                 if(x % 2 * 160==0) width=30;
                 else witdh=330;

                 g.drawString(ItemList.get(x).name,width ,     /*This is only for the coordinates->*/ (x / 2 * 35)+90); // Item Name
                  // Here it shows the number for the Item -> x5 for Potion
                 g.drawString(String.valueOf(ItemList.get(x).number) +   /*This is only for the coordinates->*/ "x" ,(x % 2 * 250)+270,(x / 2 * 35)+90); 
           

                }

Now if I use the Potion I make this:


ItemList.get(ItemNr).number=ItemList.get(ItemNr).number-1;

ItemNr is here 0 for the Potion…
But now in in the ItemMenu there is still written x5.
When I give out the Number with System.out then I get the correct amount -> x4.

System.out.println("Number: " + ItemList.get(0).number );

But why not in the Menu?
Do you need more to know?

#2

Maybe you aren’t calling repaint()? If it does repaint and still uses the wrong number, are you sure ItemNr is 0?

#3

Yes it is ItemNr 0 :frowning:
I wrote it with System.out.
Grrr where is the error _

#4

is this code copied from your program? or is it typed up in the post? cause I noticed u mispelled width, and that would throw a compiler error I imagine.

but the point is that if you typed this up, maybe u typed something correctly that u typed incorrectly in your code :), so can u copy ur code?

also, can you add the line

System.out.println( ItemList.get(x).name + “:” + ItemList.get(x).number);

after the last drawstring? and see what sort of stuff that gives out, because there might be some issue you don’t even know about and maybe just printing one might not make it apparent.

also something to try would be to set specifically the quantity of the item to like 2, just for testing purposes because if that doesnt show then that might narrow down your problem.

#5

Also in Java, the usual conventions is to start variables with lower case so we don’t get confused between variables and class names.

But yes please show us the entire code.

#6

Yes I typed it with hand.
I have all variables in german so I had to change it for you.

I will try your System.out. tomorrow.

[quote]But yes please show us the entire code.
[/quote]
Its a lot of code but I will paste it here tomorrow.

#7

Better use englisch names for your variables :wink: Just think about how much shorter “Speed” is compared to the german “Geschwindigkeit”. English has the fancy ability to be very short on the expression highway imho :smiley: Also this makes it easier for you to show code to other people around the world.

#8

Japanese is even shorter, typically only one kanji per word, but you’d have to learn a few thousand kanjis to be able to use it properly. xD I don’t think kanjis are supported as names in Java though…

#9

They are. But it would be kinda confusing sometimes, as much japanese depends on the context…

but yeah always write code in English - even comments

On topic: Items/Inventory are of course data structures, so you need a fair amount of debugging to get it right.
I mean even in Final Fantasy VII there was this bug with the 2xItem materia - you could increment one item infinitely

#10

Ok when I put this line in the ItemMenu it shows the wrong number of Items.
But if I put this line in my CheckMenuMovement Method it shows the correct number…

So how can it be when my ItemMenu Method is activated but there is still the wrong amount?

Im using Slick and this has 3 Methods:
Init
Update
Render

In render I have make(I changed all variables with hand maybe there is a error):

        
   if(switch.Map)
        drawMap(g);
  
 else if (switch.Menu)
         drawMenu(g);

DRAWMENU:


else if (switch.MenuItem)
                      GameMenu.paintItem(g);

GameMenu paintItem:


public void paintItem(Graphics g){
        
        if(!switch.ItemTargetMenu)  //ItemTargetMenu is the window which come when you choose an Item and press Enter.
        {
             g.setFont(font2);
             g.drawImage(item,0,0); //Item Menu Picture
             g.drawImage(ItemCursor, switch.MenuCursorX , switch.MenuCursorY); //Cursor
            

             //Draw Items
             for( x=0;x<ItemListe.size();x++)
             {
                 if(x % 2 * 160==0) breite=30;
                 else breite=330;

                 g.drawString(ItemListe.get(x).name,breite,(x / 2 * 35)+90); // Item Name
                 g.drawString(String.valueOf(ItemListe.get(x).number) + "x" ,(x % 2 * 250)+270,(x / 2 * 35)+90); //Number
                 g.drawString(ItemListe.get(schalter.ItemNr).description,30,30); //Description
                 
              // System.out.println(""+ItemListe.get(x).name + " : "+ bank.ItemListe.get(x).number);
              //Shows wrong amount
                
                
              }
             
        }
            //If Item is chooses activate TargetMenu
         else if(switch.ItemTargetMenu)
             {
                 
                 g.drawImage(itemTargetMenu,200,40); //TargetMenu Picture
                 draw_ItemMenu_ActorStats(g);
                 
                 
             }
                          
       }

Ok in Update I have the function:
checkMenuMovement();

The code


//If no item is use then normal ItemMenu
                if(!switch.ItemTargetMenu)
                {
                 
           //     for(int i=0;i<ItemListe.size();i++)
           //    System.out.println(""+ItemListe.get(i).name + " : "+ ItemListe.get(i).number); 
           //Shows the correct amount         
                    
                       //Right Movement
                        if(MenuRight && switch.MenuCursorX<320 && (switch.ItemNr+1)<ItemListe.size())
                        {
                            playSE(Globals.SOUND_HIT, 1.0f, 1.0f);
                            switch.MenuCursorX=switch.MenuCursorX+300;
                            switch.ItemNr+=1;
                        }
                        //Down Movement
                        else if(MenuDown && switch.MenuCursorY<480 && (switch.ItemNr+2)<ItemListe.size())
                        {
                            playSE(Globals.SOUND_HIT, 1.0f, 1.0f);
                            switch.MenuCursorY=switch.MenuCursorY+35;
                            switch.ItemNr+=2;
                        }
                        //Left
                        else if (MenuLeft && schalter.MenuCursorX > 30 && (switch.ItemNr-1)>=0) 
                        {
                             playSE(Globals.SOUND_HIT, 1.0f, 1.0f);
                             switch.MenuCursorX=schalter.MenuCursorX-300;
                             switch.ItemNr-=1;
                        }
                        //Up
                        else if(MenuUp && switch.MenuCursorY>85 && (switch.ItemNr-2)>=0)
                        {
                            playSE(Globals.SOUND_HIT, 1.0f, 1.0f);
                            switch.MenuCursorY=switch.MenuCursorY-35;
                            switch.ItemNr-=2;
                        }
               


                //If the user choose an item 
                else if(EnterKeyDown)
                {
                    switch.ItemTargetMenu=true;
                    switch.MenuCursorX=210;
                    switch.MenuCursorY=75;
                }
                
                
               }
                //User have to choose the actor who he want to use the item.
                else if(switch.ItemTargetMenu)
                {
                      //Down
                      if(MenuDown && switch.MenuCursorY<480 && (switch.ActorNr+1)<ActorsList.size())
                      {
                        playSE(Globals.SOUND_HIT, 1.0f, 1.0f);
                        switch.MenuCursorY=switch.MenuCursorY+35;
                        switch.ActorNr+=1;
                      }
                      //Up
                     else if(MenuUp && switch.MenuCursorY>220 && (switch.ActorNr-1)>=0)
                      {
                        playSE(Globals.SOUND_HIT, 1.0f, 1.0f);
                        switch.MenuCursorY=switch.MenuCursorY-35;
                        switch.ActorNr-=1;
                      }
                     //Cancel
                       else if(Num0)
                       {
                        switch.ItemTargetMenu=false;
                        Num0=false;
                       }
                
                
                //Item Use
                else if(EnterKeyDown)
                {
                    int HPvalue=0;
                    int heilen=0;
                    
                    //HP from the player
                    HPvalue=ActorsListe.get(switch.ActorNr).MaxHP-ActorsListe.get(switch.ActorNr).HP;
                          
                    //Potion
                    if(ItemListe.get(switch.ItemNr).name=="Trank" && ItemListe.get(switch.ItemNr).number>0)
                    {
                        if(HPvalue==0)
                        {
                             playSE(Globals.SOUND_HIT, 1.0f, 1.0f);
                             EnterKeyDown=false;
                             
                        }
                        
                        else if(HPvalue>75)
                        {
                        ActorsListe.get(switch.ActorNr).HP=ActorsListe.get(switch.ActorNr).HP+75;
                        ItemListe.get(switch.ItemNr).number=ItemListe.get(switch.ItemNr).number-1; //Decrease the amount
                                                                        
                        EnterKeyDown=false;
                        }
                                
                        else if(HPvalue<75)
                        {
                        heilen=HPvalue;
                        ActorsListe.get(switch.ActorNr).HP=ActorsListe.get(switch.ActorNr).HP+heilen;
                        ItemListe.get(switch.ItemNr).number=ItemListe.get(switch.ItemNr).number-1;
                                                  
                        EnterKeyDown=false;
                        }
                            
                    }
                    
                                       
                    
                }
              }
            }
#11

Sounds like you have 2 different ItemNr objects?

#12

just out of curiosity, your player wouldnt happen to have 75 health would he? cause if I understand your code correctly, if he has 75 health then he won’t get any health from it, because you have less than and greater than,b ut not equal to.

#13

[quote]Sounds like you have 2 different ItemNr objects?
[/quote]
ItemNr is a variable and I only use one.

[quote]just out of curiosity, your player wouldnt happen to have 75 health would he? cause if I understand your code correctly, if he has 75 health then he won’t get any health from it, because you have less than and greater than,b ut not equal to.
[/quote]
I decrease MAXHP-HP.
So when he has full HP:

100 -100 = 0.

Then he wont get healed.

Oh I forgot to mention I created the ItemList/ActorList in my Database Class.
Maybe where is the error?

And because of that I create 2 Database Object to access the Arrays.
In my Game and Menu Class I make:

Database bank = new Datenbase();

And then I use

g.drawString(bank.ItemListe.get(x).name

But how can I do it that I only need one Object but use it with both class?

EDIT: Ok I will put the external Menu Class inside my Game Class. Then its ok but it get more chaotic>.<"

#14

Then that’s the problem, the ItemNr in one Database is different from the other Database :stuck_out_tongue:

#15

Ok I put everything from my menu class inside the game class from Slick.
Now its fine :smiley:

BUT, what if I wanted to use another seperate class for my menu?
How can I get access to an object which was created in another class?

#16

Pass it as constructor argument?