CVS cleanup

Engines, Libraries and Tools Xith3D Forums
#1

I have done a little cleanup on CVS. I have structured the demo folder on xith-tk and deleted the demo folder on xith-core (since it’s contents were correctely moved to tk by Amos).

There are further clean ups I’d like to do, but I don’t want to do them without asking the community beforehand.

xith-core

  • delete the www folder and move the contents to joombla
  • refactor the junit folder contents into the toolkit-test-package
  • delete the nbproject folder and move the project.xml file to root
  • delete the reference folder, since the contained zip-archive’s contents are regulary in the com.xith3d.utility package on CVS

xith-tk

  • delete the www folder, since it is not used anymore (developed through joombla)
  • delete the ext folder and move the two txt-files to docs or third-party/jaxb
  • remove the toolkit-folder (the folder called toolkit) and merge the contents with the test packages

This would shrink the (two) project(s) without loosing anything and would make them more trasparent to everyone.

What do you say?

Marvin

#2

I object to this one.

#3

Yes, I couldn’t imagine you didn’t object to anything. And I know, you’re the author of this one. That’s becaus I didn’t move it on my own. But Do you have a reason, too.

#4

This folder and the files inside are required to build Xith from Netbeans 5.0+

If you delete them (or the folder) then the Netbeans project is no longer functional.

Ciao Matthias

#5

Ah, OK. I suspected something like that. Then we will leave it like that.

#6

About the ext folder in the toolkit:

The readmy contained in it tells us that this folder is the reference folder for third-party libraries. Which is not the case. There is a library called third-party which does the job. But ext could do it, too. But we should concentrate on one folder. Either we keep the third-party folder and put the ext folder’s contents in it or vise versa. Then we should of course do it on the core, too.

Please believe me, Croft: I don’t want to offend you. But we shouldn’t have two folders for the same job. So we could stay with the so far used one or with your ext folder. But we shouldn’t have both.

What do you say?

#7

One more point, that I would like to clean up:

the Canvas3D class resides in the scenegraph package, but it actually belongs to the render package. So we could move it to the render package and create a new class Canvas3D in scenegraph which does nothing more than extend com.xith3d.render.Canvas3D and being deprecated.

This would not hurt the backwards compatiblity in a way an we’d be just one step cleaner.

Is it ok for you?

#8

Most of the changes (except the nbproject one, of course) are OK for me.
I know Croft had good reasons to create an ext folder and I’m sure we can find something logical. (And change the README if needed).
(@Qudus : hey calm down. Not everybody can have the same coding ways… Croft has his owns, and yet its contributions are really, really (in)valuable)

#9

[quote="<MagicSpark.org [ BlueSky ]>,post:8,topic:27936"]
I know Croft had good reasons to create an ext folder and I’m sure we can find something logical. (And change the README if needed).
[/quote]
Yes, I know. And if corft would say something about his reasons we could quickly discover a good way of doing. :wink:

[quote="<MagicSpark.org [ BlueSky ]>,post:8,topic:27936"]
(@Qudus : hey calm down. Not everybody can have the same coding ways… Croft has his owns, …)
[/quote]
Yes I know. I just want to bring some tidyness into the project and have ever respected other’s styles. I just wanted to discuss on it and do the best for the project we can achieve.

[quote="<MagicSpark.org [ BlueSky ]>,post:8,topic:27936"]
…and yet its contributions are really, really (in)valuable)
[/quote]
Yes, I know. I have never ever denied this, but even emphasized it. I just want to know a reason when someone objects something.

#10

My preference would be to merge them into the ext directory:
http://www.java-gaming.org/forums/index.php?topic=13972.msg111110#msg111110
http://www.java-gaming.org/forums/index.php?topic=13972.msg111382#msg111382
https://xith-tk.dev.java.net/source/browse/xith-tk/ext/readme.txt?rev=1.1&view=auto&content-type=text/vnd.viewcvs-markup

#11

Well, actually it’s the third-party directory which is being used, not the “ext” one. It’s not the fact that you’ve written onto the “ext” folder or created it on CVS that justify it.
“ext” is just 10 times less clear than “third-party”.

Soon I’ll believe you can’t comply with existing things and you always have to do your owns…

#12

I also prefer to stay with the third-party folder. The use of three letter codes is just legacy. You’ll never type in this folder name without bash-completion or so, which was the reason years ago to use three-letter -codes.

Today we won’t have a problem with longer folder names and it definitely is clearer. So let’s stay with third-party. And the readmy file in the ext folder is just wrong as it is now. But it is well weritten so we should adept it in case we stay with third-party.

#13

xith-core

  • delete the www folder and move the contents to joombla –> Amos, could you please do that. I’m not skilled enough in joombla.
  • refactor the junit folder contents into the toolkit-test-package –> Maybe we should wait for Will to do that, because, there’s a base class missing. Do we even need this?
  • delete the reference folder, since the contained zip-archive’s contents are regulary in the com.xith3d.utility package on CVS –> done.

xith-tk

  • delete the www folder, since it is not used anymore (developed through joombla) –> done.
  • delete the ext folder and move the two txt-files to docs or third-party/jaxb –> done. Please forgive me, Croft.
  • remove the toolkit-folder (the folder called toolkit) and merge the contents with the test packages –> done.
#14

As far as I know the junit stuff never really worked, and it’s certainly not up to date, I’d probably just toast it. This is not saying that junit is bad - just that that folder is basically useless in it’s current form.

I think the web site probably already has all the contents of that www folder, so I’d probably just remove it.

Regarding third-party vs ext, I think there’s something to be said for sticking with the standards that are in place. If everyone just did things their own way it would get very messy fast. If the standard needs to be changed, then there should be good reason and a discussion, the result of which should be adopted across the board. But that’s just my 2 cents.

Cheers,
Will

#15

OK. Thanks, Will. Then I’ll delete junit and www from the core.

#16

xith-core

  • delete the www folder and move the contents to joombla –> deleted.
  • refactor the junit folder contents into the toolkit-test-package –> deleted.
  • delete the reference folder, since the contained zip-archive’s contents are regulary in the com.xith3d.utility package on CVS –> done.

xith-tk

  • delete the www folder, since it is not used anymore (developed through joombla) –> done.
  • delete the ext folder and move the two txt-files to docs or third-party/jaxb –> done. Please forgive me, Croft.
  • remove the toolkit-folder (the folder called toolkit) and merge the contents with the test packages –> done.
#17

@Qudus : Joomla!, not Joombla… And remember, “Break”, not “Brake” ;D ;D ;D ;D ;D ;D ;D