Automated webstart-maker: need game authors

TheAnalogKid · March 15, 2005, 5:58pm

Hey blah3,

I’m going to upload Mighty Bubbles on JGF tonight.

TheAnalogKid · March 16, 2005, 12:26am

blah3,

I tried to upload my game but I had 2 problems:

The first time I tried I entered a too long description of the game (more than 750 characters), which I think resulted in an exception stack trace. Please check your code to see if it could be that.
I created the game with a different name (Mighty Bubbles Demo) and then tried to upload all the jars but after a long delay I got the following stack trace:


Please contact the admin / dev-team
Copy and paste everything below this line when contacting them


--------------------------------------------------------------------------------

Referer URL:/controllers/release-game

Throwable:java.lang.Exception: Failed to parse file ID that was uploaded as file with field name = jar2

Line Source File 
201 In GameReleaseController.java 
141 ...called from CMSControllersService.java 
117 ...called from bExpeditionGeos.java 
38 ...called from Geos.java 
62 ...called from HttpPostControllerService.java 
251 ...called from bAsynchronousService.java 
330 ...called from bModule.java 
534 ...called from Thread.java

That’s it.

blahblahblahh · March 16, 2005, 5:09am

[quote]blah3,

I tried to upload my game but I had 2 problems:

The first time I tried I entered a too long description of the game (more than 750 characters), which I think resulted
[/quote]
That shouldn’t happen (can’t think how it might happen) so it’s going to be very hard to deal with without seeing the stack trace. The trailing characters are stripped automatically (with previous testing), and sinece the game itself didn’t create in the DB by the looks of things - although I did receive the email notification that you’d created it - I very much doubt it’s to do with the 750 chars.

It could be any of 4 or 5 completely different issues, each of which involves another 2-3 classes. Realistically, I can’t even look into it without a stack trace (unless I can find one in the server logs by hand, but off the top of my head it doesn’t log the trace if it prints it to the user.

Delay == time taken by your browser to upload file ;D. unfortunately, most browsers are dumb and don’t show an upload dialog, which is sad :(.

Off the top of my head, that exception means that there was something wrong with the filename that you uploaded, and it crashed the HTTP parse code in some way. It’s certainly just a generic “the parse method crashed unexpectedly” message.

Anyway, this one I believe I can look into because IIRC it logs extra data - and if not, I need to add more detail to the log message.

blahblahblahh · March 16, 2005, 5:24am

Added some extra info to that second exception message (thoguht I’d already done this a few weeks ago, but nevermind), and also corrected an exception that was being thrown in the logs in the last 12 hours that MIGHT have been what caused your first attempt to fail (but I don’t think so).

I’m sorry that you’re still beta-testing this

PS: if you don’t mind, I’d be grateful if you had another quick go at doing mighty bubbles. If it crashes again, grab that stack trace. If not, hopefully we can replace mightybubblesdemo with it - unfortuantely, it’s non trivial to rename a game at the moment (game name == unique ID and is used in many places).

Vorax · March 16, 2005, 9:46am

You may want to think about taking the hit and changing that sooner rather then later. The longer db design problems exist, the more painful they become to fix. A sequence or identity field could save you a lot of pain.

blahblahblahh · March 16, 2005, 9:53am

Thanks for the sage advice, but using the name as unique ID actually solves a lot of problems and makes maintenance a heck of a lot easier. Having thought about it carefully for a couple of months, I’m happy not to be able to rename games in return for the benefits. ID fields are a common habit but not always appropriate for the problem space.

TheAnalogKid · March 16, 2005, 2:38pm

I’ve tried to reproduce the bug with the same behaviors but it went well this time! :-/ Sometime life is strange… : Ho! Maybe I don’t have the same version of IE than the one I have at home? Could it be related?

Concerning the name of the files I don’t use any special character apart spaces, - and _

I’ll check again the names…

TheAnalogKid · March 16, 2005, 2:41pm

Correction here: I don’t use spaces in file names. I’ve just checked it.

TheAnalogKid · March 16, 2005, 2:45pm

As I see the alpha page of Mighty Bubbles Demo, the only jar that seem to have been uploaded successfully is dom4j.jar.

Don’t know if it could help to investigate?

blahblahblahh · March 16, 2005, 4:38pm

[quote]As I see the alpha page of Mighty Bubbles Demo, the only jar that seem to have been uploaded successfully is dom4j.jar.
[/quote]
Are you looking at your private page for uploading files? If so, try re-uploading individual files, see if it works or throws an error?

TheAnalogKid · March 16, 2005, 4:45pm

I can but it’s time consuming doing all those tests. Have you found something on your side?

TheAnalogKid · March 18, 2005, 4:28pm

blah3,

I’ve uploaded the necessary jars for Windows version of the game only. 2 problems:

I can’t set any system property, which might cause bad performance on some systems. Especially for translucent images.
No way to set the main class of the game. You assume that the jar contains a manifest file describing the main class. I’m used to specify the main class in the jnlp file.

Could you delete the Mighty Bubbles Demo entry please? I also need to update the descrition of the game since it contains crap data at the end.

Thanks

blahblahblahh · March 24, 2005, 8:10pm

Now that it’s easter, I’m hoping to have a good few days to just sit down and do some longstanding needed fixes for JGF.

I’ll be starting with the open-files/out-of-buffer-memory problems (ugh), moving on to analog’s problems, then hoping (if I’m brave enough) to get a full libraries-upload working, and then move on to more interesting things and/or fixing some layout issues with MSIE being too crap to let you edit articles etc.

moogie · March 27, 2005, 6:25am

I have a bug report:

One of the JARs being uploaded caused the following error:

Referer URL:/controllers/release-game

Throwable:java.lang.NumberFormatException: null

Line Source File
436 In Integer.java
518 …called from Integer.java
231 …called from GameReleaseController.java
141 …called from CMSControllersService.java
117 …called from bExpeditionGeos.java
38 …called from Geos.java
62 …called from HttpPostControllerService.java
251 …called from bAsynchronousService.java
330 …called from bModule.java
534 …called from Thread.java

This seems to have corrupted the database entry for the game as it now says that the game is 302018 bytes.

The game in question: http://javagamesfactory.org/views/view-game?name=AnacondaNet

I have created a new game page and have called it Anaconda_Net… i am currently uploading to it now. I will let you know if this one works correctly.

blahblahblahh · March 27, 2005, 9:56am

Thanks.

However, this is bizarre. Either a very strange bug in the HTTP parser, or I suspect this is a browser problem (maybe a bug in the javascript processing, or an incompatibility between your browser and the js source?). What happened is that - apparently - one of the form fields which has a value of 0 and increases by 1 every time you add a nativelibrary instead had a value of “null”. Hence the exception when I try to find out the value of it :(.

Even more weird is that this only affected you once. That would suggest to me that it’s a browser bug. I know that Mozilla, for instance, still has some major bugs in it’s javascript execution, such that you can execute the same script 5 times in a row and get different results.

Anyway, I’ll add a specific workaround for this, that catches that possibility and prints a “your browser might be broken; please email me your browser version - but try again because it might work second time” message, and then leave it and see if it happens again.

It must be said that I’m not a js programmer - but then again there’s only 20 lines of it, it’s all legal syntax, and how bad can js execution engines be?

PS: Could you confirm whether this FORCED you to create a new game, or if you just did so anyway to see if you could? For most things, you should just be able to try again a second time without creating a new game…

moogie · March 27, 2005, 10:08am

Well i am using IE 6 so i guess that is the culprit

It did force me to make a new game as when i re-loaded the game information page it did not come up with a link the alpha release at first.

After i had already created the new game i noticed that the link to the alpha release was back on the old game, however it still was giving errorneously high file size.

I am only on a 28.8k modem so it takes a heck of a long time to upload to see if the changes worked, so i decided to stick with the known working new game.

If at all possible i would like to be able to delete the old game.

blahblahblahh · March 27, 2005, 10:52am

[quote]Well i am using IE 6 so i guess that is the culprit
[/quote]
The only MSIE I test with is 6, because none of the others support HTML+CSS, and even 6 doesn’t support it fully. I’ve never had any problems with uploads - only with mozilla :(.

Interesting. That should only happen if it thinks you are not logged-in, or if you are logged-in as someone different from the person who created the game (only the author has permission to upload new versions).

Fair enough. I asked because most people so far who have problems just create an entire new game, and that then means the names are wrong, and I have to login and delete the old ones :(.

I’ve been considering making it so you can only create one game at a time, and need to get it accepted by an admin before you can create another, just to avoid having lots appearing and then being deleted (i.e. if the game doesn’t work and you can’t upload it, then an admin would delete it for you and let you try again, for instance).

OTOH … I’m wondering now if there is a bug with something to do with having spaces in filenames, because most people try first with spaces, and second time without. There used to be a bug on the server where it didn’t handle them properly, which was fixed a while ago, but maybe it’s still (somewhere) sending them to the browser unconverted and causing the browser to get confused instead.

That’s no problem, I will do it today. It only takes a few seconds :).

blahblahblahh · March 27, 2005, 8:06pm

Just spent an hour discovering that bloody MySQL bloody JDBC driver doesn’t always throw an exception when an INSERT fails.

Unit tests? They’ve heard of them. They don’t really know what they are, though.

Grumble.

TheAnalogKid · March 27, 2005, 8:33pm

[quote]blah3,

I’ve uploaded the necessary jars for Windows version of the game only. 2 problems:

I can’t set any system property, which might cause bad performance on some systems. Especially for translucent images.
No way to set the main class of the game. You assume that the jar contains a manifest file describing the main class. I’m used to specify the main class in the jnlp file.

Could you delete the Mighty Bubbles Demo entry please? I also need to update the descrition of the game since it contains crap data at the end.

Thanks
[/quote]
Adam,

I’ve added the attribute Main-Class to the Manifest.mf in the game jar but it still have the same problem:


An error occurred while launching/running the application.

Title: Mighty Bubbles
Vendor: Author: theanalogkid
Category: Launch File Error

No main class specified for application

TheAnalogKid · March 27, 2005, 8:37pm

and here is the JNLPException:


JNLPException[category: Launch File Error : Exception: null : LaunchDesc: 
<jnlp spec="1.0+" codebase="http://www.javagamesfactory.org/attachments/game/Mighty+Bubbles/" href="http://www.javagamesfactory.org/jnlp/Mighty+Bubbles/alpha.jnlp">
  <information>
    <title>Mighty Bubbles</title>
    <vendor>Author: theanalogkid</vendor>
    <homepage href="http://www.javagamesfactory.org/views/view-game?Mighty+Bubbles"/>
    <description kind="one-line">description test</description>
    <icon href="http://www.javagamesfactory.org/attachments/game/Mighty+Bubbles/game-logo.jpg" kind="default"/>
    <offline-allowed/>
  </information>
  <security>
    <all-permissions/>
  </security>
  <resources>
    <jar href="http://www.javagamesfactory.org/attachments/game/Mighty+Bubbles/alpha/dom4j.jar" download="eager" main="false"/>
    <jar href="http://www.javagamesfactory.org/attachments/game/Mighty+Bubbles/alpha/gagetimer1_1.jar" download="eager" main="false"/>
    <jar href="http://www.javagamesfactory.org/attachments/game/Mighty+Bubbles/alpha/jinput.jar" download="eager" main="false"/>
    <jar href="http://www.javagamesfactory.org/attachments/game/Mighty+Bubbles/alpha/jutils.jar" download="eager" main="false"/>
    <jar href="http://www.javagamesfactory.org/attachments/game/Mighty+Bubbles/alpha/mighty_bubbles-demo.jar" download="eager" main="false"/>
    <jar href="http://www.javagamesfactory.org/attachments/game/Mighty+Bubbles/alpha/win32-dxinput.jar" download="eager" main="false"/>
    <jar href="http://www.javagamesfactory.org/attachments/game/Mighty+Bubbles/alpha/win32-dxinput-native.jar" download="eager" main="false"/>
    <jar href="http://www.javagamesfactory.org/attachments/game/Mighty+Bubbles/alpha/win32-fmod-native.jar" download="eager" main="false"/>
    <jar href="http://www.javagamesfactory.org/attachments/game/Mighty+Bubbles/alpha/win32-gagetimer1_1-native.jar" download="eager" main="false"/>
    <jar href="http://www.javagamesfactory.org/attachments/game/Mighty+Bubbles/alpha/win32-lwjgl_fmod3-native.jar" download="eager" main="false"/>
    <jar href="http://www.javagamesfactory.org/attachments/game/Mighty+Bubbles/alpha/win32-lwjgl-native.jar" download="eager" main="false"/>
    <j2se href="http://java.sun.com/products/autodl/j2se" version="1.4.2+"/>
  </resources>
  <application-desc/>
</jnlp> ]
      at com.sun.javaws.LaunchDownload.getMainClassName(Unknown Source)
      at com.sun.javaws.Launcher.continueLaunch(Unknown Source)
      at com.sun.javaws.Launcher.handleApplicationDesc(Unknown Source)
      at com.sun.javaws.Launcher.handleLaunchFile(Unknown Source)
      at com.sun.javaws.Launcher.run(Unknown Source)
      at java.lang.Thread.run(Unknown Source)

I assure you that my jar is built correctly because I tested it without specify the main class in my .jnlp and it worked.

I use Firefox 1.0. and it does the same thing with IE 6.0

Any idea?