Hi,
I have to create a game in 12x12 array, with a player trying to avoid hunters to gain points. I have done collision, boundaries etc, however I cannot move my hunters, even though the code looks well, if you could, please have a look at it and point me into a right direction/fix my error, thanks!
Most people in this forum won’t download zipped files and look through all your code to find your error. You need to learn how to debug your game and if you are still confused, paste the code here in code blocks:
code goes here Hi Arom,
I just had a look at your other thread where you had already pasted some of your code. Like ra4king said, I also don’t like to download archives of unknown source.
If your code still looks like this, then I would say that you are missing a game loop. The main method draws the map and then there are some conditions which will end after being executed once.
public static void main(String[] args) {
....
for (int r = 0; r < a2.length; r++) {
... }
System.out.println("Input your move");
move = in.nextLine();
if (move.equalsIgnoreCase("w")) {
// move up
// repaint
// check for collision
// check for health
} elseif {.... } // no loop here. Main will end and the game will be over.
}
I think there should be a look around your input and conditions. And, of course, you would have to replace the comments by something that is actually doing stuff. If you have done so already, then please post the relevant piece of code.
I have added a lot of stuff, and got the game very much built, however I think I have an error in my Board class;
public class Board {
public String emptyfield = "-";
public String [][]a2 = new String[12][12];
public Hunter hunters[] = new Hunter[5];
public void paint(){
int numHunters =5 ;
for (int i =0; i < numHunters; i ++){
hunters[i] = new Hunter(11,11,"H");
}
Player player = new Player();
for (int r = 0 ; r < a2.length; r++){
for (int c= 0; c <a2[r].length; c++){
a2 [r][c] = emptyfield;
a2[Player.x][Player.y] = Player.name;
for (int i = 0; i < numHunters; i++){
Hunter h = hunters[i];
a2[h.x][h.y]=h.name;
}
System.out.print(" "+a2[r][c]);
}
System.out.println("");
}
System.out.println(" Strength: "+Player.hp);System.out.println(" Score "+Player.score);
}
public void route1(){
Board board = new Board();
Hunter Hunter = new Hunter(11,11,"H");
Scanner in = new Scanner(System.in);
Random number = new Random(2);
int random = number.nextInt(2);
if(random ==1)
Hunter.x = Hunter.x -1;
else
Hunter.y = Hunter.y -1;
}
The
Route1
Class is being used for the movement of the hunters as the player is moved around, the value of my Hunter.x and y (possibly) stays at the same value, is the value set back to 11 while executing the
Paint
code?
Each Paint and Route1 are executed on the player movement(WSAD - enter).
Hunter Hunter = new Hunter(11,11,"H");
I did not examine everything in detail but what looked wrong was the piece above.
Can you name the variable same as the class? If you can, then it is at least bad style.
I would prefer something like
Hunter hunter = new Hunter(...);
I see a route1() and paint() method. Maybe you mixed up the terms?
I don’t completely understand what you are doing. You say that both methods are called every time the user presses one of the movement keys.
I have now looked a bit more at your code. It seems that you are creating new objects at each cycle of your game loop. And you will always give them the same starting coordinates.
If you want to save the state of player and hunters over the loop, then you should initialize your player once, create the object and use the reference to this one object without throwing it away.
public void route1(){
Board board = new Board();
Hunter Hunter = new Hunter(11,11,"H");
Scanner in = new Scanner(System.in);
Random number = new Random(2);
int random = number.nextInt(2);
if(random ==1)
Hunter.x = Hunter.x -1;
else
Hunter.y = Hunter.y -1;
}
A variable has a certain scope. If you create a variable within a method (like “Hunter” here. use hunter as name, not Hunter. Hunter is your class), it will be in your program’s memory until the method ends.
This is what you do:
Player does something. Hunters have to be updated
What you should do:
Your Hunter-class has only a constructor
public Hunter(int x, int y, String name){
this.x = x;
this.y = y;
this.name = name;
}
You should have a move() method and access to your coordinates as well.
Then you could tell the hunter to move. Then you would not create the hunter
within the route1() method but outside your game loop in your Main class. Then,
when it comes to updating the hunters’ positions, you do something like this:
for (int i = 0; i < numberofhunters; i++) {
hunter[i].move();
}
The move() method would then contain all the code to generate the new coordinates
of the hunter. It would store the coordinates within the object and would not forget
them.
There are a lot of strange things in your code. I would suggest doing some Java tutorials
first to get familiar with its basic concepts before doing a bigger project. Learn about
classes, objects and methods. Learn about the scope of variables and their visibility.
A small one class example does not provide as many chances to create bugs and will
improve the understanding. Once you have done this, go back to your project, find the
mistakes and strange things, start new and finish your project.