New feature: java syntax highlighting (finally!)

General Discussions
#7

I hate any of IE but I tested with 7 at work for testing purposes: Single scroll bar but as you mentionned, no color syntax, which is normal for IE.

#8

Double scrollbar in Chrome 8 is solved now.

Javascript cleaned up too.

#9

Works in MSIE 9 now too.

Could anybody please test MSIE 7 and 8 ?

#10

Looking good. Thanks for hashing these features out so quickly.

Some things in the code are kinda weird:


if(count > 0)
{
	foundAnyPre=true;
}
else if(foundAnyPre)
{
	SyntaxHighlighter.all();
	return;
}

I don’t really see where foundAnyPre is useful … couldn’t you just:


if(count > 0)
{
	SyntaxHighlighter.all();
	return;
}

Also, what is the purpose of the delay? Are you waiting for the page to have content?

If so… just place that script directly before the tag. That way, when the script runs, the entire DOM will be ready for you to instantly query/fix. No need to delay.

#11

works fine in Chrome now, gj :slight_smile:

Broken in IE8 for me

and

#12

The only thing I did was:


   <style  type="text/css">
      div.code > div > div.syntaxhighlighter { overflow: hidden !important; }
   </style>

:persecutioncomplex:

#13

Looks great in Chrome / OSX here. :slight_smile:

#14

Disabled it in MSIE again. I’m not going to spend more time on that.

#15

It seems to work fine in Firefox, after a delay.

Did you consider doing it server side? There is a PEAR package called Text_Highlighter that looks like it could do it.

#16

I did consider it, but I really like not to have to mess to much with the SMF internals… for the moment, I think the client-side syntax highlighter is acceptable.

#17

That IE crash happens because you are trying to manipulate the DOM before it has been completely loaded. See Woogley’s post for a quick fix.

I’m not a huge fan of jQuery, but at least it takes care of these things for you.

#18

I already put it after the – it’s another problem in MSIE, and I will look into it later.

#19

The syntax highlighting doesn’t scroll horizontally (on FireFox). Eg:
http://www.java-gaming.org/index.php/topic,22899.msg189422.html#msg189422

#20

[quote]The syntax highlighting doesn’t scroll horizontally (on FireFox). Eg:
http://www.java-gaming.org/index.php/topic,22899.msg189422.html#msg189422
[/quote]
Meaning to report this too. Same problem on Chrome.

To fix the problem in chrome
change:

div.code > div > div.syntaxhighlighter {
overflow: hidden !important;
}

to:

div.code > div > div.syntaxhighlighter {
overflow: visible !important;
}

No idea if this breaks anything.

#21

Please read the thread.

#22

Please read my post.

#23

Please hand me a toast. :smiley:

@Topic:
Great job! That’s awesome 8)

#24

Please direct me to the coast.

#25

Fleas directly to the coat.

#26

This boat will never float.